Open
Conversation
|
Hey @ivanape Please sign both the commits to pass the DCO check |
* feat: add LabelMatchMode field to Workload struct Signed-off-by: XploY04 <2004agarwalyash@gmail.com> * feat: add LabelMatchMode to ApplicationParams and update target formatting Signed-off-by: XploY04 <2004agarwalyash@gmail.com> * chore: add modern Kubebuilder config structure with labelMatchMode support - Generated by controller-gen v0.16.5 - Includes CRDs with labelMatchMode field in OpenAPI schema - Follows Kubebuilder v3+ project layout Signed-off-by: XploY04 <2004agarwalyash@gmail.com> * update: bump controller-tools version to v0.16.5 and clean up build tags Signed-off-by: XploY04 <2004agarwalyash@gmail.com> * gofmt chaosengine_types.go Signed-off-by: XploY04 <2004agarwalyash@gmail.com> --------- Signed-off-by: XploY04 <2004agarwalyash@gmail.com> Signed-off-by: Iván Álvarez <ivanape@inditex.com>
Signed-off-by: Iván Álvarez <ivanape@inditex.com>
b5073bf to
ec0bca9
Compare
Author
|
Hi @Maximus-08, Thanks for the heads-up. I’ve now signed both commits to satisfy the DCO check. Please let me know if anything else needs to be fixed. |
manuelacgu
approved these changes
Mar 16, 2026
Author
|
Hi @Maximus-08, To avoid blocking the PR, should I take any action to solve the errors checks? Thank you! |
|
Hey @ivanape the maintainers will look into this, can you message on Litmus-dev slack regarding the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes
Fixes litmuschaos/litmus#5444
It could be great if we can also upgrade the base docker image for the operator and the runner. I will open a new PR for the runner.
Regards,